This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Suggested redo for snap scroller based on classname #611
Open
whatfield73 wants to merge 2 commits intoPrinzhorn:masterfrom
Open
Suggested redo for snap scroller based on classname #611whatfield73 wants to merge 2 commits intoPrinzhorn:masterfrom
whatfield73 wants to merge 2 commits intoPrinzhorn:masterfrom
Conversation
Redid a past snap scroller. Works better overall. Not perfect - on scrolling up from bottom needs to scroll past the last snapped container.
Fixed file reference
Author
|
also played around with snapping only when within a certain range of the marked div if you want that code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redid the old snap scroller example. Works better for me. Handles top/bottom cases better. Based it on classname for greater flexibility.